Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for glob params #1294

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

matthewmcgarvey
Copy link
Member

Purpose

Fixes #1292

Description

Adds support for route globbing that was added to LuckyRouter in luckyframework/lucky_router@e21fca1.

There are several invalid states being checked with compilation errors:

  • More than one glob is defined
  • Glob is not at the end of the path
  • Glob has dashes in the name
  • Glob doesn't start with *: or isn't exactly *

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@matthewmcgarvey matthewmcgarvey merged commit 820232b into luckyframework:master Oct 29, 2020
@matthewmcgarvey matthewmcgarvey deleted the glob-params branch October 29, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add route globbing
2 participants