Inline render_html_page to change compilation error #1373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
No connected issue
Description
Before
After
Notice in the "Before" that the first code reference was a macro and not the usage site that caused the error. By removing the
render_html_page
we actually see the usage site in the error which will help people track down issues.That macro was extracted here but you'll notice that this PR achieves the same level of DRY-ness without the separate macro.
Checklist
crystal tool format spec src
./script/setup
./script/test