Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe events #1423

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Pipe events #1423

merged 3 commits into from
Mar 5, 2021

Conversation

jwoertink
Copy link
Member

Purpose

This is an extension required for the upcoming Breeze updates.

Description

Similar to what we've added in Avram, this adds in a new PulsarEvent that publishes each time a pipe runs. When a pipe is executed, we publish if the pipe was continued or halted for both before and after pipes.

Right now, there's nothing subscribing to these events, so when they publish, nothing actually happens. In the future, Breeze will subscribe to these to track the pipes.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

…h subscribed events. Eventually this will be used in Breeze to manage your pipes
@jwoertink
Copy link
Member Author

@paulcsmith if you get a free min, would love to get your thoughts on this. No rush since I'll probably just update breeze and wait for the next Lucky release to add this stuff in

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a position with one event class makes sense 👍

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

src/lucky/events/pipe_event.cr Show resolved Hide resolved
@jwoertink
Copy link
Member Author

Awesome! Thanks for the review!

@jwoertink jwoertink merged commit b611066 into master Mar 5, 2021
@jwoertink jwoertink deleted the breeze_pipes branch March 5, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants