-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipe events #1423
Pipe events #1423
Conversation
…h subscribed events. Eventually this will be used in Breeze to manage your pipes
@paulcsmith if you get a free min, would love to get your thoughts on this. No rush since I'll probably just update breeze and wait for the next Lucky release to add this stuff in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a position
with one event class makes sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Awesome! Thanks for the review! |
Purpose
This is an extension required for the upcoming Breeze updates.
Description
Similar to what we've added in Avram, this adds in a new PulsarEvent that publishes each time a pipe runs. When a pipe is executed, we publish if the pipe was continued or halted for both before and after pipes.
Right now, there's nothing subscribing to these events, so when they publish, nothing actually happens. In the future, Breeze will subscribe to these to track the pipes.
Checklist
crystal tool format spec src
./script/setup
./script/test