Update the build.release task #1454
Conversation
| @@ -6,20 +6,19 @@ class Build::Release < LuckyCli::Task | |||
|
|
|||
| summary "Compile app for production" | |||
|
|
|||
| def initialize(@io : IO = STDOUT, @error_io : IO = STDERR) | |||
| end | |||
| property error_io : IO = STDERR | |||
There was a problem hiding this comment.
This should be added in to LuckyCli::Task directly to match up with output.
|
|
||
| def call | ||
| command = "crystal build --release src/start_server.cr" | ||
| command = "crystal build --release src/start_server.cr -o bin/start_server" | ||
|
|
||
| log "Building binary with '#{command}" |
There was a problem hiding this comment.
Why does this print out, but the one below doesn't?
There was a problem hiding this comment.
Maybe try adding an else and check if the process isn't completing successfully?
There was a problem hiding this comment.
ah. Good call. It is failing.. 🤔 but I guess why.
There was a problem hiding this comment.
oh, but that still doesn't explain why IO::Memory is printing to STDOUT 🤨
There was a problem hiding this comment.
Ohh, it's actually the second spec that is printing to stdout, it doesn't have it's output changed, only error_io
There was a problem hiding this comment.
ooohhhh 😂 yup. That fixes it. Thanks!
Purpose
Fixes #1387
Description
We should now be building all binaries to the
bin/dir. When we updated to do this, thebuild.releasetask was missed. This also uses theoutputproperty from LuckyCli.One strange thing I couldn't figure out is that
log "Building binary with '#{command}"prints out to the screen now 🤔 Even though it's aIO::Memory, it still seems to print just that one message. It doesn't print out the other one...Checklist
crystal tool format spec src./script/setup./script/test