Combine server bind_tcp and listen #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Nov 28, 2021
src/lucky/base_app_server.cr
Outdated
| server.bind_tcp host, port | ||
| server.listen | ||
| server.listen(host, port) |
There was a problem hiding this comment.
Why do we even define this here? We end up overriding it in the generated apps https://github.com/luckyframework/lucky_cli/blob/master/src/web_app_skeleton/src/app_server.cr.ecr#L28-L32 which includes the extra arg for the reuse_port... 🤔 Seems like we could just make this method abstract, then do this cleanup on the CLI repo. What do you think?
There was a problem hiding this comment.
Good catch, I made the update here and opened luckyframework/lucky_cli#699
jwoertink
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP::Server#listenprovides an overload that does exactly what we are doing on two lines.https://crystal-lang.org/api/1.0.0/HTTP/Server.html#listen(host:String,port:Int32,reuse_port:Bool=false)-instance-method