Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for rounding up on hours. #1651

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

russ
Copy link
Contributor

@russ russ commented Jan 17, 2022

Fixes #1649

Purpose

Allowing for a more expected return when a time is closer to the higher hour mark.

Description

Just a small tweak to see if the time is closer to the next hour.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jwoertink jwoertink merged commit 3d11af7 into luckyframework:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time_ago_in_words always rounds down
2 participants