Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lucky::CookieJar#[] and #[]= #1678

Merged

Conversation

grepsedawk
Copy link
Contributor

Adds easier access to cookies by adding the typical key/value syntax
for cookies get/set operations

In the future, this could potentially even implement all of Enumerable({K, V}), but
these methods are super helpful as is to provide hash-like access to cookies

Copy link
Member

@matthewmcgarvey matthewmcgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types need to be specified. Otherwise looks good

@grepsedawk
Copy link
Contributor Author

The types need to be specified

Ah cool, I thought being a direct alias the implicit types would be fine.
Will change that.

Adds easier access to cookies by adding the typical key/value syntax
for cookies get/set operations

In the future, this could potentially even implement all of Enumerable({K, V}), but
these methods are super helpful as is to provide hash-like access to cookies
@matthewmcgarvey matthewmcgarvey merged commit 91864a6 into luckyframework:main Mar 16, 2022
@grepsedawk grepsedawk deleted the cookie-square-bracket branch March 16, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants