-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to pass crystal --error-trace to lucky watch task. #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. My only thought here is that we should probqbly see if the Crystal team could add a SHOW_FULL_CRYSTAL_ERROR_TRACE
ENV var that can be set to 1
or true
so that it people can set it in their shell or before a command and not worry about it passing the flag. This can be helpful to any command line tool written in Crystal
Added an issue to Crystal here: crystal-lang/crystal#8374 |
I've added a little todo note for us to revisit if that crystal issue ever becomes a thing. I think getting this merged in for now will be good just so people can take advantage of the full errors. I'll merge once these builds finish and pass. |
Agreed! Thanks @jwoertink |
@jwoertink, thanks for this. Super helpful! |
![]() ![]() ![]() @jwoertink not fixed! |
@Napolskih You have to make sure that your |
What version is listed in your |
Purpose
Fixes #947
Description
Allows you to pass crystal's
--error-trace
flag in tolucky watch
command. When you runlucky dev
, and encounter a compiler error, you'll be given the full trace each time.Checklist
crystal tool format spec src
./script/setup
./script/test