Database marked as changed only if icons are actually downloaded #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database won't be marked as changed (and won't show that it needs saving) if no icons are downloaded. Also added numbers to error messages to identify them easier.
|
Thanks @h-a-s-h, if this PR is updated so that it is purely for the improvement mentioned in the subject, I will accept it. I'm not interested in the other changes (to error messages and redirect limit) though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database won't be marked as changed anymore (and won't show that it needs saving) if no icons are actually downloaded and associated with the entries.
Also added numbers to error messages to identify them easier and allow easier debugging.