Add support for ES6/ES2015 module loading #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. The downside is that this does not compile the ES2015 to ES5. |
|
Sorry. Probably a bit premature on this one. |
|
@domchristie Are there any plans to move to a proper semver of collapse-whitespace? The git url supplied in Turndown breaks for users behind a corporate proxy. |
|
Fixed in v4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ES6/ES2015 module loading by using
export defaultrather thanmodule.exports =in the source, as well as updating themoduleandjsnext:mainfields inpackage.json.I am currently using
collapse-whitespaceandvoid-elementsin Turndown and noticed that thevoidElementsarray was being duplicated in the build version. It seems that Rollup is unable to squash identical imports when using CommonJS modules. Using ES6 module exports seems to fix this issue.