Add example tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I was planning to work on this topic to integrate tests in my cookiecutter project for custom component. |
raman325
added a commit
to raman325/cookiecutter-homeassistant-custom-component
that referenced
this pull request
Jan 6, 2021
ludeeus
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Add executing the tests to:
- https://github.com/custom-components/integration_blueprint/blob/master/.github/workflows/push.yml
- https://github.com/custom-components/integration_blueprint/blob/master/.github/workflows/pull.yml
And it's good to go 👍
|
Don't forget to pin the requirements as done in oncleben31/cookiecutter-homeassistant-custom-component#112 to avoid potential difficulties for new install |
oncleben31
added a commit
to oncleben31/cookiecutter-homeassistant-custom-component
that referenced
this pull request
Jan 13, 2021
* add tests using ludeeus/integration_blueprint#50 as base * move tests folder to the right place * add test files to files table * try to fix * move requirements to appropriate folder * add a note to contributing about tests * add a note to contributing about tests * Update docs/guide.rst Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * Update {{cookiecutter.project_name}}/CONTRIBUTING.md Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * Update {{cookiecutter.project_name}}/tests/test_init.py Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * address review comments * add more comments * fix description for requirements files * add more comments * update gitignore and fix CONTRIBUTING * add dummy init file so that pytest works * Update {{cookiecutter.project_name}}/requirements_test.txt Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * fix import statements * Fix spelling * bypass setup in config flow * fix comment * incorporate comments that were in integration_blueprint PR * add tests to isort known_first_party Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com>
oncleben31
pushed a commit
to oncleben31/cookiecutter-homeassistant-custom-component-instance
that referenced
this pull request
Jan 13, 2021
* add tests using ludeeus/integration_blueprint#50 as base * move tests folder to the right place * add test files to files table * try to fix * move requirements to appropriate folder * add a note to contributing about tests * add a note to contributing about tests * Update docs/guide.rst Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * Update {{cookiecutter.project_name}}/CONTRIBUTING.md Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * Update {{cookiecutter.project_name}}/tests/test_init.py Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * address review comments * add more comments * fix description for requirements files * add more comments * update gitignore and fix CONTRIBUTING * add dummy init file so that pytest works * Update {{cookiecutter.project_name}}/requirements_test.txt Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> * fix import statements * Fix spelling * bypass setup in config flow * fix comment * incorporate comments that were in integration_blueprint PR * add tests to isort known_first_party Co-authored-by: Oncleben31 <oncleben31@users.noreply.github.com> Original-Commit: oncleben31/cookiecutter-homeassistant-custom-component@b5c30b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core integrations can look at other integrations to learn how to write tests but there is no equivalent for custom components. This PR adds 100% test coverage to
integration_blueprintalong with some additional information which will help authors write tests for their custom components.