Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several gtags related issues: mission update_gtags.cmd & lack of execution permission #336

Closed
wants to merge 5 commits into from

Conversation

skywind3000
Copy link

@skywind3000 skywind3000 commented Oct 8, 2022

After the 39dc3ee commit, gtags generation will require a update_gtags.sh or update_gtags.cmd script to execute the actual gtags command.

But:

  1. "update_gtags.sh" on linux platform lacks execution permission
  2. "update_gtags.cmd" is missing on Windows platform.

And gtags_cscope became unusable on both Linux and Windows due to these two issues.

This PR fixed:

@skywind3000 skywind3000 changed the title fix missing execution permission fix several gtags related issues: mission update_gtags.cmd & lack of execution permission Oct 8, 2022
@skywind3000
Copy link
Author

skywind3000 commented Oct 8, 2022

@ludovicchabant , maybe you are busy, but do you have several minutes to review this ?
because gtags_cscope is not usable on both Linux and Windows right now.

and many users complaint this in the issues.

Taverius and others added 2 commits October 15, 2022 03:21
* Powershell takes double quoted "arguments" literally and just errors out on a gutentags call
* You could unquote all the strings and try to deal with the mess that is
* Or you can just prepend '& ' to the whole thing and it automagically works
@ludovicchabant
Copy link
Owner

Thanks for this! Yes, I'm slow with dealing with PRs and issues -- apologies for that.

What are the pros/cons between your version of update_gtags.cmd and the one that came from a previous PR? (see 4108ba2 )

@skywind3000
Copy link
Author

skywind3000 commented Nov 24, 2022

  1. My version is directly translated from update_gtags.sh, but his version is not.
  2. My version supports FILE_LIST_CMD (like update_gtags.sh), but his version doesn't
  3. The arguments parsing routine of his version is incorrect, he can only accept --incremental as the only one possible argument for gtags, but my version accepts arbitrary arguments for gtags.

@ludovicchabant
Copy link
Owner

That's the impression I got from a quick diff, thanks. I updated the file with your version, included the Powershell support fix, but stripped the changeset that fixed the file permissions since this is already in. See 1337b18. Thanks a lot!

@skywind3000
Copy link
Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants