-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
> Error: more than one library with package name 'com.lufinkey.react.spotify' #28
Comments
Yeah, as mentioned in the README, this is a bug with |
I managed to find all duplicate entries. The fix for a double link is as follows:
Perhaps it'd be good to mention this fix for a double link in the instructions of your package install on npm? |
So do you think I should also make an install script that echoes information
about it, or just add it to the README?
…On Jan 19, 2018 11:55 AM, "Robert Oost" ***@***.***> wrote:
I managed to find all duplicate entries. The fix for a double link is as
follows:
remove the wrong lines from:
android/settings.gradle
android/app/build.gradle
android/app/src/main/java/.../MainApplication.java
Perhaps it'd be good to mention this fix for a double link in the
instructions of your package install on npm?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHdTUao52yMuyJ7QfofpBBltSCi5PTkAks5tMMkMgaJpZM4Rktfz>
.
|
I'd say add it to the bottom of readme on npm, and an installscript would be good aswell. |
Perhaps a better solution for now would be to release the package under a different name. The current version breaks the project every time someone executes react-native-link. It's a minor annoyance for me, but the members of our team that are working on entirely different sections of the app are not having a good developer experience, to say the least. |
I'd say use the GitHub package instead of the npm one. That's why I've maintained the master branch and the npm branch |
If I were to release the package under a different name, do you have any recommendations? |
How about: react-native-spotifysdk? |
I tried that one. It collides with react-native-spotify-sdk because it's too similar |
Oh, that's annoying! How about: rn-spotify-sdk It's the same prefix as for example rn-splash-screen |
@lufinkey are you happy with the above suggestion? It would make use really happy if you could get the library published without the scoped prefix so we can workaround the react-native / gradle issue. Thanks! |
Yeah I'll try to deprecate the previous name and switch over on the next update |
I'll probably work on fixing react native link soon, just to let you know, because scoped packages are the new norm, and should not have to rename |
Looks like the pull-request fixing this issue in react-native got approved! Will we be able to close this issue soon? |
I'm still going to convert it away from a scoped package anyway, so I'm going to leave this open so that I remember to do that on the next release |
the package has been rescoped as |
In the instructions on how to install
react-native-spotify
through npm, you mention having to replace "@lufinkey/react-native-spotify
" with "@lufinkey_react-native-spotify
" in several .gradle files. This works during initial setup, but after linking the project again, and running npm i, my project broke down.It seems the replaced versions of the string have been raised from the dead to haunt me, as both versions of the string are now present in my .gradle files.
Removing the lines that use a "/" does allow the project to start on android, but it fails immediately ( as shown in the image below ).
I have the feeling that this has something to do with this double module issue. Any thoughts on how to fix this?
See Image here
The text was updated successfully, but these errors were encountered: