Fixed regenerating config on each build #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When output file already exist, the script is not ran, even when configuration has changed. This causes a bug when using
react-native run-ios --scheme <scheme>
with different configurations for different schemes, resulting in having old configuration in theConfig
object, while environment variables are set properly.Cleaning build folder (or derived data) manually before build with changed configuration fixes this problem, but also causes a rebuild of all dependencies which may be much longer, depending on the size of the project (and obviously is error prone).
When the
output_files
section of the script does not contain path to the generated file, it is recreated for every build, thus forcing the pod to rebuild, and results in having a proper config, while extending the build time imperceptibly.