Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regenerating config on each build #458

Merged
merged 1 commit into from
May 26, 2020

Conversation

Przytua
Copy link
Contributor

@Przytua Przytua commented May 25, 2020

When output file already exist, the script is not ran, even when configuration has changed. This causes a bug when using react-native run-ios --scheme <scheme> with different configurations for different schemes, resulting in having old configuration in the Config object, while environment variables are set properly.

Cleaning build folder (or derived data) manually before build with changed configuration fixes this problem, but also causes a rebuild of all dependencies which may be much longer, depending on the size of the project (and obviously is error prone).

When the output_files section of the script does not contain path to the generated file, it is recreated for every build, thus forcing the pod to rebuild, and results in having a proper config, while extending the build time imperceptibly.

@height
Copy link

height bot commented May 25, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Collaborator

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants