Soumikd mailscape v3 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra features : get credentials from file to prevent leaking on git repo. Changes from official instructions : use SSL instead of TLS.
Changes : moved getCredentials to a new class Improvement : removed the unneeded String results[] and made the no. of emails to be retrieved be known from the function call.
Changes : renamed downloadMail to getMail
starMail function created. created a basic UI to attach multiple files and send emails. Changes : renamed downloadMail to getMail. adjusted sendMail function to be used by the UI
srijan2002
reviewed
Oct 23, 2021
Changes : get messages from Gmail by UID, therefore reducing time to fetch attachments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions :
starMail function created.
created a basic UI to attach multiple files and send emails.
Changes :
renamed downloadMail to getMail.
adjusted sendMail function to be used by the UI