Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh feed #66

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Refresh feed #66

merged 1 commit into from
Apr 5, 2024

Conversation

lui5fl
Copy link
Owner

@lui5fl lui5fl commented Apr 4, 2024

  • Modify FeedViewModel to use the async version of the HackerNewsServiceProtocol.items method, and define the onRefreshRequest method, which is to be called by FeedView through refreshable
  • Fix a test in DateExtensionTests which is failing due to DST (should look into properly fixing it in the future though)

@lui5fl lui5fl self-assigned this Apr 4, 2024
@lui5fl lui5fl linked an issue Apr 4, 2024 that may be closed by this pull request
@lui5fl lui5fl merged commit 79cb30a into main Apr 5, 2024
2 checks passed
@lui5fl lui5fl deleted the feature/20-refresh-feed branch April 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh feed
1 participant