-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds auth support for Redis 6 #1130
Conversation
@luin This should be ready to be reviewed. Let me know if there's anything I need to fix in this PR. |
@luin Is there anything I can change / help to do that can help get this merged? I think I've covered all of the cases in the tests I wrote, but if there's a test case I missed out, if you can describe the case, I can write a test for it. Thanks and appreciate all the work you do to keep this library fast and secure! |
Sorry for the late response. Code-wise it looks good to me 👍, just left two comments. I'll test thoroughly and merge the PR this weekend. |
Co-authored-by: Zihua Li <i@zihua.li>
Co-authored-by: Zihua Li <i@zihua.li>
# [4.17.0](v4.16.3...v4.17.0) (2020-05-16) ### Features * add auth support for Redis 6 ([#1130](#1130)) ([ad5b455](ad5b455))
🎉 This PR is included in version 4.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.17.0](redis/ioredis@v4.16.3...v4.17.0) (2020-05-16) ### Features * add auth support for Redis 6 ([#1130](redis/ioredis#1130)) ([ad5b455](redis/ioredis@ad5b455))
This PR contains the following changes:
username
optional key to theIRedisOptions
interface and instantiation options.Fixes #1097