Add support for Auth with username & password (Redis 6)

[gkorland]

No description provided.

[techpanga]

I am able to get this worked by passing below in new Redis({})... Hope this helps.

password: ['user','password']

[gkorland]

@techpanga is seems like it can work as a workaround, but it doesn't feel like good solution for the long term

[gkorland]

@techpanga also it seems like all the user must have +info on their ACL otherwise it fails when creating the connection.

[ioredis] Unhandled error event: ReplyError: NOPERM this user has no permissions to run the 'info' command or its subcommand
    at parseError (/home/guy/redisclients/TestIoRedis/node_modules/redis-parser/lib/parser.js:179:12)
    at parseType (/home/guy/redisclients/TestIoRedis/node_modules/redis-parser/lib/parser.js:302:14)

[techpanga]

@gkorland , Yes. it is workaround only. Thank you.

[luin]

Hey @gkorland @techpanga, actually giving password a ['user', 'password'] does work as expected and I think what we need to do is just documenting this usage.

For the NOPERM error, if the user doesn't have +info you should disable enableReadyCheck option like new Redis({ enableReadyCheck: false }).

wdyt?

[asyrique]

@luin This workaround only works if you're initializing ioredis using the new Redis({options})approach and passing in the password key in the options object.

However, we're initializing ioredis using the url string approach, passing in something like redis://foo:bar@somehost:someport, and this now fails (previously with Redis <6, we'd pass in the password without a user, i.e. redis://:bar@somehost:someport).

I'd be happy to submit a PR for this that would fix the the URL string parsing as well as adding an extra optional option user to the options object, if you're not already working on it.

Let me know!

[luin]

Yeah gotcha. PR is welcome Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Asyrique Thevendran <notifications@github.com> Sent: Tuesday, May 5, 2020 2:40:28 PM To: luin/ioredis <ioredis@noreply.github.com> Cc: Zihua Li <i@zihua.li>; Mention <mention@noreply.github.com> Subject: Re: [luin/ioredis] Add support for Auth with username & password (Redis 6) (#1097) @luin<https://github.com/luin> This workaround only works if you're initializing ioredis using the new Redis({options})approach and passing in the password key in the options object. However, we're initializing ioredis using the url string approach, passing in something like redis://foo:bar@somehost:someport, and this now fails (previously with Redis <6, we'd pass in the password without a user, i.e. redis://:bar@somehost:someport). I'd be happy to submit a PR for this that would fix the the URL string parsing as well as adding an extra optional option user to the options object, if you're not already working on it. Let me know! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1097 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAE3H7RL4L3YD45I6ETXAQDRP6YFZANCNFSM4MCRP4RQ>.

[ioredis-robot]

🎉 This issue has been resolved in version 4.17.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[danieltseitlin]

is this also supported in the @types/ioredis as well? can't see to be able to pass password a ['user', 'password']

[reshreshus]

A workaround would be to use a connection string

    RedisModule.forRoot({
      type: 'single',
      url: 'redis://default:password@localhost:6379',
    }),