TypeScript: add types for the array methods (map, filter, etc)
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 3.32 kB ℹ️ View Unchanged
|
michalczaplinski
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
I think this looks good! Nice work @luisherranz . I just have the one comment above.
so it is maintained when doing `tsc`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TypeScript: add types for the array methods (
map,filter, etc).Why
Because if not, the
$prefix can't be used on their callbacks or resulting arrays.How
With a new interface that extends
Arrayand adds the new method types.