-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for filenames with spaces #40
Conversation
…a/action-sh-checker into rasa/spaces-in-filenames-wip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it :)
https://github.com/luizm/action-sh-checker/releases/tag/v0.2.0 It is a pre-release I did a quick validation and it seems good, @rasa @haraldh if you could use this version as well I really appreciate it. |
https://github.com/dracutdevs/dracut/pull/1414/checks?check_run_id=2467329776 |
if [ "$SHFMT_DISABLE" != "1" ]; then | ||
echo -e "Validating shell scripts files using shfmt\n" | ||
# shellcheck disable=SC2086 | ||
shfmt_error="$(eval shfmt $SHFMT_OPTS -d $sh_files)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lost the -d
, per #44
This PR adds the following features:
I've tested everything including the SH_CHECKER_COMMENT logic.