Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extmarks for markdown list markers #47

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sarmong
Copy link

@sarmong sarmong commented Jan 8, 2023

#46

lua/headlines/init.lua Outdated Show resolved Hide resolved
------------------------------------------------------------------------------
list_marker_string *list_marker_string*

Specifies the string that is used to display list markers.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention that it replaces all kinds of list items?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by all kinds of list items? All types of list item markers?

IMHO, list markers already mean all.

doc/headlines.txt Outdated Show resolved Hide resolved
lua/headlines/init.lua Show resolved Hide resolved
sarmong and others added 2 commits January 9, 2023 20:38
Co-authored-by: Benoit de Chezelles <bew@users.noreply.github.com>
@lukas-reineke
Copy link
Owner

I'm okay with adding this, but it should work for all filetypes, not just Markdown.

@sarmong
Copy link
Author

sarmong commented Jan 13, 2023

@lukas-reineke I don't know what we should do about neorg and org.

Neorg's unordered list items look like this and I don't think there is value in substituting them all.

    - Unordered list level 1
    -- Unordered list level 2
    --- Unordered list level 3
    ---- Unordered list level 4
    ----- Unordered list level 5
    ------ Unordered list level 6

Org treesitter doesn't differentiate between ordered and unordered lists, so it will not be possible.

@sarmong
Copy link
Author

sarmong commented Feb 5, 2023

I found a bug that when you horizontally scroll the window and the first column is invisible, the extmark is still shown on the first visible column. Will look into it when I have time.

@cultab
Copy link

cultab commented Jun 18, 2023

Neorg's unordered list items look like this and I don't think there is value in substituting them all.

iirc Neorg has it's own conceal module included that substitutes them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants