Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix indented fenced code block and block quote #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix indented fenced code block and block quote #54

wants to merge 2 commits into from

Conversation

tomtomjhj
Copy link

@tomtomjhj tomtomjhj commented Jun 3, 2023 •
edited
Loading

fixes #52.

Example:

* list item
  > 123
  > asdf

* > 123
  > asdf

> aawef

  > quote line 1
  > quote line 2

>asdf

* item 1
  ```
  code block
  ```
* item 2

image

@tomtomjhj tomtomjhj changed the title fix: lua for statement end index is not exclusive fix interaction of list, code block, and block quote Jun 3, 2023
@tomtomjhj tomtomjhj mentioned this pull request Jun 3, 2023
Closed
@tomtomjhj tomtomjhj changed the title fix interaction of list, code block, and block quote fix indented fenced code block and block quote Jun 3, 2023
@francium
Copy link
Contributor

francium commented Jun 3, 2023

I've tried this out and it's working well for me. Would be great to get this in if the code changes look good

lukas-reineke
lukas-reineke reviewed Jun 6, 2023
View reviewed changes
Copy link
Owner

@lukas-reineke lukas-reineke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! But this solution still doesn't really fix the underlying problem. Things like nested quotes are still breaking

> quote
>
> > nested quote
> > nested quote

I'll take a look myself today

@lukas-reineke
Copy link
Owner

I made #55
That should fix all the issues with quotes, I think.
Can you take a look if you still find anything broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-reineke lukas-reineke lukas-reineke left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

markdown: bullet lists don't play nice with block quotes and code blocks
3 participants
@tomtomjhj @francium @lukas-reineke