fix: make_formatting_params assumes the current buffer
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liskin
reviewed
Oct 9, 2024
Comment on lines
+87
to
+91
| local tabSize = vim.api.nvim_get_option_value("shiftwidth", { buf = bufnr }) | ||
| local expandtab = vim.api.nvim_get_option_value("expandtab", { buf = bufnr }) | ||
| if expandtab or tabSize == 0 then | ||
| tabSize = vim.api.nvim_get_option_value("tabstop", { buf = bufnr }) | ||
| end |
There was a problem hiding this comment.
Why is this logic different from the one used earlier (https://github.com/neovim/neovim/blob/e268fcbdaa1e0e0cee3b513e62581d35bb937d40/runtime/lua/vim/lsp/util.lua#L2078-L2083)? Can't we just use get_effective_tabstop directly? Like liskin@3757ac4
Specifically, vim.lsp.util.make_formatting_params will use sw even if expandtab, but your implementation will use tabstop instead in such case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim.lsp.util.make_formatting_paramsassumes the buffer the formatting params are generated for is the current buffer. in LSP-format this is not always the case.fix #92
fix #58