Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0 #69

Merged
merged 43 commits into from
Apr 5, 2021
Merged

v4.0 #69

merged 43 commits into from
Apr 5, 2021

Conversation

lukaskubanek
Copy link
Owner

No description provided.

- Introduced type alias OrderedDictionary.LazyValues
- Removed OrderedDictionarySlice, OrderedDictionaryKeys & OrderedDictionaryValues

Closes #67
- Removed override subscript(bounds:) since it’s now inherited from MutableCollection
- Implemented getter for subscript(position:)
- Implemented override for swarAt(_:_:)
- Tweaked implementations of sort methods
- Split tests into multiple files
- Added tests for functionality coming from MutableCollection
- Introduced a dedicated slice type OrderedDictionarySlice
- Used new pattern for reordering methods with internal methods that take a range
- Included all reorderering methods from MutableCollection in both the base and slice types
- Added tests for access through slice
- Removed _unsafeValue(forKey:)
- Removed canUpdate(_:at:keyPresentAtIndex:)
- Refactored preconditions
- Regrouped code
@lukaskubanek lukaskubanek marked this pull request as ready for review April 5, 2021 15:35
@lukaskubanek lukaskubanek merged commit c63ab5a into master Apr 5, 2021
@lukaskubanek lukaskubanek deleted the v4.0 branch April 5, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant