Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in documentation #279

Closed
stevenkbennett opened this issue Jan 14, 2021 · 3 comments
Closed

Typo in documentation #279

stevenkbennett opened this issue Jan 14, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@stevenkbennett
Copy link
Contributor

image

Says fg.with_atoms() when it should say amine.with_atoms()
@stevenkbennett
Copy link
Contributor Author

On this page: https://stk.readthedocs.io/en/latest/stk.molecular.functional_groups.functional_groups.functional_group.html

@stevenkbennett
Copy link
Contributor Author

Also should nitrogen, hydrogen and hydrogen be in something itterable?

@lukasturcani lukasturcani added the bug Something isn't working label Jan 15, 2021
@lukasturcani
Copy link
Owner

tyty!

nah , I prefer they are not grouped together, because the order ambiguous

@lukasturcani lukasturcani mentioned this issue May 20, 2021
Merged
lukasturcani added a commit that referenced this issue May 21, 2021
@lukasturcani
Use doctest (#336)
159f278 
Related Issues: #329 #320 #298 #304 #289 #279 #253

Switch code blocks to doctest so that code examples are run and tested.
Also adds the running of the doctest blocks to CI and fixes a bunch of typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasturcani @stevenkbennett