MNG-27_question_generator #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusz-sm
commented
Jan 7, 2021
lukaszdutka
reviewed
Jan 8, 2021
lukaszdutka
reviewed
Jan 8, 2021
lukaszdutka
reviewed
Jan 8, 2021
src/service/QuestionGenerator.js
Outdated
| for (let i = 1; i <= 4; i++) { | ||
| currentQuestionsArray.push(randomNumberInRange(this.minPokeId, this.maxPokeId, this.askedQuestions)); | ||
| }; | ||
| this.askedQuestions = this.askedQuestions.concat(currentQuestionsArray); |
There was a problem hiding this comment.
In my opinion it would be better to use push() instead of concat() here.
Check: https://stackoverflow.com/questions/44572026/difference-between-concat-and-push
but both works fine 🤷
lukaszdutka
requested changes
Jan 8, 2021
There was a problem hiding this comment.
also, the algorithm is wrong - you mixed askedQuestions array and currentQuestionArray array. Those should be used differently.
Reminder/hint:
the only nonrepeating things are:
- 4/6 answers in one question should be nonrepeating (it is
currentQuestionArray) - all 30 correct answers in whole quiz should be nonrepeating (it is
askedQuestions), bad answers can within whole quiz can repeat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.