Mng 49 fill results modal #34
Conversation
src/app/quizPage.js
Outdated
| @@ -76,7 +83,8 @@ export async function renderNextQuestion(generator) { | |||
| }) | |||
| } | |||
| } else { // no more questions left | |||
| console.log("You WON!, but sorry, we still don't have any summary page"); // TODO create summary page redirection | |||
| fillResultsModal(GAME_HANDLER) | |||
There was a problem hiding this comment.
It should be GAME_HANDLER.getResults(timeLeft) - you want to base on object from getResults, not on the "private" properties of GAME_HANDLER
src/app/fillResultsModal.js
Outdated
| if (questionItem.isCorrect === true) { | ||
| tableCell.querySelector('.tableWithResultsYourAnswer').style.border = '2px solid green'; | ||
| } else { | ||
| tableCell.querySelector('.tableWithResultsYourAnswer').style.border = '2px solid red'; | ||
| } |
There was a problem hiding this comment.
Can be simplified to:
tableCell.querySelector('.tableWithResultsYourAnswer').style.border = questionItem.isCorrect ? '2px solid green' : '2px solid red';
src/app/fillResultsModal.js
Outdated
|
|
||
| const tableCell = document.createElement('tr'); | ||
| tableCell.className = 'tableWithResultsQA'; | ||
| if ((questionItem.question).substring(0, 3) !== 'http') { |
There was a problem hiding this comment.
oh, it's cute but implementation shouldn't base on question starting with 'http' :P It doesn't tell much to other people. It would be better to pass "mode" to fillResultsModal function (or maybe even better - make it a property of gameHandlerResults) and decide based on mode.
src/app/fillResultsModal.js
Outdated
| const tableCell = document.createElement('tr'); | ||
| tableCell.className = 'tableWithResultsQA'; | ||
|
|
||
| if (mode.name === 'WHAT_DOES_THIS_POKEMON_LOOK_LIKE') { |
There was a problem hiding this comment.
It would be better to reuse contants from modes file (like in PokemonService) - by this way you do not risk making a typo in string literal :)
mode === WHO_IS_THAT_POKEMON
There was a problem hiding this comment.
Think about: "what will happen if somebody changes literals and mode.name will return different, but really similar string?"
Then this code would not work :/
No description provided.