Autocompletion off + button "Play" #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszdutka
reviewed
Jan 14, 2021
index.html
Outdated
| @@ -47,7 +47,7 @@ | |||
| </div> | |||
|
|
|||
| <div id='startGame' class="secondColumn spanInPortrait disableWithPopUpScreen"> | |||
| <input type='button' id='startGameButton' class="buttonWithText" value='PLAY'> | |||
| <input type='button' id='startGameButton' class="buttonWithText" value='PLAY' autocomplete='off'> | |||
lukaszdutka
reviewed
Jan 14, 2021
src/app/App.js
Outdated
Comment on lines
44
to
49
| document.querySelector('#enterYourNameInput').addEventListener("change", () =>{ | ||
| document.querySelector("#startGameButton").addEventListener("click", () => { | ||
| const userName = document.querySelector('#enterYourNameInput').value; | ||
| renderQuizPage(SELECTED_MODE, userName, options.quizMaxTime) | ||
| }); | ||
| }) |
There was a problem hiding this comment.
I don't think this is a good approach. By this way you will be adding new event listener to #startGameButton every time you change something on name input. If somebody will write 1000 letters there -> then there will be 1000 listeners that will render quiz page. Not good :)
Better approach is look at this:
https://stackoverflow.com/questions/7067005/disable-button-whenever-a-text-field-is-empty-dynamically
- make "PLAY" button disabled by default.
- add "onkeyup" (not sure about exact name) event listener to the "name input" that will execute something like this:
function stoppedTyping(){
if(this.value.length > 0) {
document.getElementById('start_button').disabled = false;
} else {
document.getElementById('start_button').disabled = true;
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.