MNG-99 & MNG-100 #21

memeraki · 2021-02-10T10:12:07Z

created menu and back button with options.
Options need to be fixed (now are default).
Animation also should be better ;)

> created menu and back button with options. Options need to be fixed (now are default). Animation also needs to look better

lukaszdutka · 2021-02-10T17:44:37Z

src/fightPage/buttonsEventListeners.ts

+    attackButtonOne.addEventListener('click', () => {
+      console.log('attack One used!');
+      setTimeout( ()=> {
+        gameHandler.generateActionButtons(player);
+      }, 500);
+      //also change player function 
+      for(let i = 0; i < battleButtons.length; i++) {
+        battleButtons[i].style.backgroundColor = 'green';
+      }
+    });
+    attackButtonTwo.addEventListener('click', () => {
+      console.log('attack Two used!');
+      setTimeout( ()=> {
+        gameHandler.generateActionButtons(player);
+      }, 500);
+      // also change player function
+      for(let i = 0; i < battleButtons.length; i++) {
+        battleButtons[i].style.backgroundColor = 'green';
+      }
+    });
+    backButton.addEventListener('click', () => {
+      //timeout and style for some button animation - the animation needs to be change
+      setTimeout( ()=> {
+        gameHandler.generateActionButtons(player);
+      }, 500);
+      for(let i = 0; i < battleButtons.length; i++) {
+        battleButtons[i].style.backgroundColor = 'green';
+      }
+    });


Don't you think there is some repeated logic, that can be extracted out? :)

lukaszdutka · 2021-02-10T17:48:58Z

src/fightPage/buttonsEventListeners.ts

+    switchButtonOne.addEventListener('click', () => {
+      console.log('pokemon One gooo!');
+      setTimeout( ()=> {
+        gameHandler.generateActionButtons(player);
+      }, 500);
+      // also change player function
+      for(let i = 0; i < battleButtons.length; i++) {
+        battleButtons[i].style.backgroundColor = 'green';
+      }
+    });
+    switchButtonTwo.addEventListener('click', () => {
+      console.log('pokemon Two gooo!');
+      setTimeout( ()=> {
+        gameHandler.generateActionButtons(player);
+      }, 500);
+      // also change player function
+      for(let i = 0; i < battleButtons.length; i++) {
+        battleButtons[i].style.backgroundColor = 'green';
+      }
+    });
+    backButton.addEventListener('click', () => {
+      //timeout and style for some button animation - the animation needs to be change
+      setTimeout( ()=> {
+        gameHandler.generateActionButtons(player);
+      }, 500);
+      for(let i = 0; i < battleButtons.length; i++) {
+        battleButtons[i].style.backgroundColor = 'green';
+      }
+    });


same here. It might be possible to extract it to one function. As input it could take: 1) button on which the event listener should be added; 2) the function it should call (i.e. eatMango(), switchToPokemon(1) or something)

lukaszdutka

I'm picking on, but it is for your own good 🙃
I am really amazed by the amount of the code you have done here, looks very structured, just as I like!

memeraki added 2 commits February 10, 2021 11:09

MNG-99 & MNG-100

a866dd0

> created menu and back button with options. Options need to be fixed (now are default). Animation also needs to look better

MNG-109 added

7de69d4

lukaszdutka reviewed Feb 10, 2021

View reviewed changes

memeraki added 2 commits February 11, 2021 10:08

added magicFunction

5d1336c

added animations for buttons

80e3d48

memeraki requested a review from AleksandraCyp February 11, 2021 09:37

AleksandraCyp approved these changes Feb 11, 2021

View reviewed changes

AleksandraCyp merged commit 05ecc60 into master Feb 11, 2021

lukaszdutka deleted the MNG-99&MNG-100-modals-for-action-buttons branch February 12, 2021 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNG-99 & MNG-100 #21

MNG-99 & MNG-100 #21

memeraki commented Feb 10, 2021

lukaszdutka Feb 10, 2021

lukaszdutka Feb 10, 2021

lukaszdutka left a comment

MNG-99 & MNG-100 #21

MNG-99 & MNG-100 #21

Conversation

memeraki commented Feb 10, 2021

lukaszdutka Feb 10, 2021

Choose a reason for hiding this comment

lukaszdutka Feb 10, 2021

Choose a reason for hiding this comment

lukaszdutka left a comment

Choose a reason for hiding this comment