Mng 89 clicking start should render choose pokemon screen #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandraCyp
requested changes
Feb 11, 2021
There was a problem hiding this comment.
Right now it successfully blocks passing to the next screen when there are no names given, but it does not do so, when the names are too long. In result, when the name is long we will see "Ash" and "Misty" instead of our names. The button should be blocked also when the name is too long (plus maybe add some info for the player about how long the name should be?)
AleksandraCyp
approved these changes
Feb 11, 2021
lukaszdutka
deleted the
MNG-89---Clicking-Start-should-render-ChoosePokemonScreen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.