Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mng 82 create player class #8

Merged
merged 7 commits into from
Feb 3, 2021
Merged

Mng 82 create player class #8

merged 7 commits into from
Feb 3, 2021

Conversation

AgataLudwiczynska
Copy link
Collaborator

No description provided.

AleksandraCyp
AleksandraCyp reviewed Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@AleksandraCyp AleksandraCyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks good!
Maybe you could also add readlonly before name and pokemons keys, but I'm not sure if it's necessary ;)

daria305
daria305 requested changes Feb 1, 2021
View reviewed changes
src/playerClass.ts Show resolved Hide resolved
src/playerClass.ts Show resolved Hide resolved
@AgataLudwiczynska
add new method
b7e4bd6 
+ add activePokemon value
+ add alivePokemons array
daria305
daria305 reviewed Feb 2, 2021
View reviewed changes
src/playerClass.ts Outdated Show resolved Hide resolved
src/playerClass.ts Outdated Show resolved Hide resolved
src/playerClass.ts Show resolved Hide resolved
daria305
daria305 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@daria305 daria305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now

@lukaszdutka lukaszdutka merged commit f3e3433 into master Feb 3, 2021
@lukaszdutka lukaszdutka deleted the MNG-82-create-player-class branch February 3, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandraCyp AleksandraCyp AleksandraCyp left review comments

@daria305 daria305 daria305 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AgataLudwiczynska @daria305 @AleksandraCyp @lukaszdutka