Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated index.js to work with node-canvas-v2 #72

Closed
wants to merge 1 commit into from

Conversation

TheDropOne
Copy link

No description provided.

@lukechilds
Copy link
Owner

Thanks for putting this together.

Can you look at the failing tests?

@TheDropOne TheDropOne closed this Mar 26, 2019
@TheDropOne TheDropOne reopened this Mar 26, 2019
@TheDropOne TheDropOne closed this Mar 26, 2019
@TheDropOne
Copy link
Author

Thanks for putting this together.

Can you look at the failing tests?

Yep, forget to update the major version of canvas dependency in package.json file. Plz check out that one #73 10/13 Tests passed correctly

@lukechilds
Copy link
Owner

Thanks, have replied on your new PR.

Also, just FYI, you don't need to create a new PR to make changes. You can just push to this branch and GitHub will update the PR.

@TheDropOne
Copy link
Author

Oh, i've missed that branch and created a new one. I will be more attentive next time, thanks =)

@lukechilds
Copy link
Owner

Yah it's no problem, just letting you know ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants