Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking variables using local with for loops #98

Merged
merged 1 commit into from Jul 13, 2023
Merged

Fix leaking variables using local with for loops #98

merged 1 commit into from Jul 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2023

This PR makes some fixes to avoid leaking shell variables into the interactive shell. To reproduce:

$ source zsh-nvm.plugin.zsh
$ echo $bin
nvm
$ echo $cmd
nvm

@ghost
Copy link
Author

ghost commented Jul 13, 2023 •
edited by ghost
Loading

@lukechilds please merge the PR. It fixes an issue where my terminal produces some output (cmd=nvm) every time a new shell is started.

I can avoid it by setting setopt TYPESET_SILENT for now, but it'll be good to merge this so I can remove that hack.

@lukechilds
Copy link
Owner

@sumit-sahrawat-sfdc thanks!

@lukechilds lukechilds merged commit 745291d into lukechilds:master Jul 13, 2023
henderea pushed a commit to henderea/zsh-nvm that referenced this pull request Aug 18, 2023
@henderea
Fix leaking variables using local with for loops (lukechilds#98)
d3db526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukechilds