-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deno): specify import versions (avoids Deno warnings) #8
Conversation
it shouldnt be pinned. otherwise we're forcing deno users to pin/hold onto a stale version for basic path-module imports |
Deno best practice recommends that all imports be versioned, hence the warning from I understand the desire to "keep current". But, as
ref: https://medium.com/deno-the-complete-reference/dependency-management-in-deno-48f1c91ad84d
ref: denoland/deno#10822 |
@lukeed , no further discussion? |
@lukeed , I believe the problem you are concerned about doesn't exist. |
☠️ ⚰️ |
- specify import versions per best practice and to avoid Deno warnings - pin to std@0.134.0 to avoid Deno prompts # refs - ref: [fix(deno): specify import versions (avoids Deno warnings)](lukeed#8) - closed as dead after being ghosted by @lukeed - ref: [fix(deno): refactor to avoid prompts during module import](yargs/yargs#2217) ## related discussion/issues [fix(node): Make global.ts evaluate synchronously](denoland/std#2098) [Execution order of imports in deno is unclear/unexpected](denoland/deno#14243) [std/node should avoid TLA](denoland/std#2097) [HowTO test that a module is *no-panic* and *no-prompt* when statically imported?](denoland/deno/issues/#15356) [Discussion ~ Bring back permission prompt behind a flag](denoland/deno/issues/#3811) [Security prompt by default (instead of throw)](denoland/deno/issues/#10183) [Seeking a better UX for permissions](denoland/deno/issues/#11061) [Design Meeting 2021-07-29 ~ `Prompt by default`](denoland/deno/issues/#11767) [permission prompt problems](denoland/deno/issues/#11936) [`deno repl` has permissions by default?](denoland/deno/issues/#12665) [Bad UX with prompt by default](denoland/deno/issues/#13730) [DENO_NO_PROMPT env var support](denoland/deno/issues/#14208) [feat: Add DENO_NO_PROMPT variable](denoland/deno/issues/#14209)
The current version causes Deno to report warnings when imported...
This pins the version to the current Deno std (0.159.0) for both scripts and removes the warnings.