Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to exports map #41

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Add types to exports map #41

merged 2 commits into from
Jan 16, 2023

Conversation

jakebailey
Copy link
Contributor

Without this, newer TS module resolution modes point out that there aren't types for these export mappings:

src/schema.test.ts:1:23 - error TS7016: Could not find a declaration file for module 'klona'. '/home/jabaile/work/python/pyright-action/node_modules/klona/dist/index.mjs' implicitly has an 'any' type.
  There are types at '/home/jabaile/work/python/pyright-action/node_modules/klona/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'klona' library may need to update its package.json or typings.

1 import { klona } from "klona";

@lukeed
Copy link
Owner

lukeed commented Jan 13, 2023

Thanks :) these should all be “index.d.ts” though

@jakebailey
Copy link
Contributor Author

Ugh yes, my mistake.

@jakebailey
Copy link
Contributor Author

Fixed!

@lukeed lukeed merged commit b3ca63d into lukeed:master Jan 16, 2023
@jakebailey jakebailey deleted the fix-types branch January 16, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants