Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not mutate process.argv #36

Merged
merged 3 commits into from
Feb 16, 2020
Merged

fix: do not mutate process.argv #36

merged 3 commits into from
Feb 16, 2020

Commits on Feb 16, 2020

  1. (fix): don't mutate process.argv with arr.splice 

    - 1.7.1 introduced some arr.splice's into the code, which caused
  mutations in process.argv, affecting downstream code

- set arr to a clone of process.argv instead so it can be freely
  mutated after
- explicitly call the parameter processArgv so code is written more
  carefully when dealing with it
- add a test to ensure process.argv is not mutated
    @agilgur5
    agilgur5 committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    8a6a568 View commit details
    Browse the repository at this point in the history

  2. chore: truncate

    @lukeed
    lukeed committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    c6a5ac2 View commit details
    Browse the repository at this point in the history

  3. chore: add & improve tests

    @lukeed
    lukeed committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    c2318ee View commit details
    Browse the repository at this point in the history