fix(sirv-cli): add missing HOST and PORT support

lukeed · Jun 1, 2019 · 04ea942 · 04ea942
1 parent 210302e
commit 04ea942
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/sirv-cli/boot.js b/packages/sirv-cli/boot.js
@@ -8,6 +8,7 @@ const tinydate = require('tinydate');
 const toPort = require('get-port');
 
 const PAD = '  ';
+const { HOST, PORT } = process.env;
 const stamp = tinydate('{HH}:{mm}:{ss}');
 
 function toTime() {
@@ -55,10 +56,11 @@ module.exports = function (dir, opts) {
 		});
 	}
 
+	opts.port = PORT || opts.port;
 	toPort(opts.port).then(port => {
 		let https = !!opts.ssl; // TODO
-		let hostname = opts.host;
-		let isOther = port !== opts.port;
+		let isOther = port != opts.port;
+		let hostname = HOST || opts.host;
 		server.listen(port, hostname, err => {
 			if (err) throw err;
 			if (opts.quiet) return;

diff --git a/packages/sirv-cli/readme.md b/packages/sirv-cli/readme.md
@@ -86,6 +86,8 @@ $ sirv start --help
     -h, --help         Displays this message
 ```
 
+> **Note:** The `HOST` and `PORT` environment variables will override flag values.
+
 
 ## License