Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL decoding in file names has been removed. Rollback it please. #110

Closed
NikolayMakhonin opened this issue Jun 2, 2021 · 1 comment
Closed

URL decoding in file names has been removed. Rollback it please. #110

NikolayMakhonin opened this issue Jun 2, 2021 · 1 comment

Comments

@NikolayMakhonin
Copy link

See this code lines:
https://github.com/lukeed/sirv/pull/64/files#r643652267
https://github.com/lukeed/sirv/pull/64/files#r643653381

Rollback please decodeURIComponent, because this issue is back: #21
@lukeed
Copy link
Owner

lukeed commented Jun 2, 2021

Sorry, this is not true. You can share a reproduction (including sirv version) & together we can inspect what specifically is going on in your case, but on its own, sirv decodes all URLs.

Heading to bed now, but happy to walk thru an example/repro tomorrow :)

@lukeed lukeed closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukeed @NikolayMakhonin