Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL encoding in file names #21

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Fix URL encoding in file names #21

merged 1 commit into from
Apr 7, 2019

Conversation

Seb35
Copy link
Contributor

@Seb35 Seb35 commented Apr 6, 2019 •
edited by lukeed
Loading

After reading this SO post and trying with a file named /my%20file%3F.txt it is searched the file named my file?.txt.

Closes #20

lukeed
lukeed approved these changes Apr 7, 2019
View reviewed changes
Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I have an upcoming fix for this, I guess we might as well ship this out for immediate fix... especially since not 100% sure on when the next version of sirv will be done.

Thank you!

@lukeed lukeed merged commit 54dde5f into lukeed:master Apr 7, 2019
@Seb35 Seb35 deleted the fix-20 branch April 8, 2019 10:11
@lukeed lukeed mentioned this pull request Sep 13, 2020
Closed
This was referenced Jun 2, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seb35 @lukeed