Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --single to be passed a path #35

Closed
Conduitry opened this issue Jul 19, 2019 · 3 comments
Closed

Allow --single to be passed a path #35

Conduitry opened this issue Jul 19, 2019 · 3 comments
Labels
has fix

Comments

@Conduitry
Copy link

The CLI's --single option should be able to be passed a path, which will be served as the catch-all response instead of the default index.html. Passing no value for the option can continue to mean what it does now.
@lukeed
Copy link
Owner

lukeed commented Jul 19, 2019

As discussed in Discord: Accepted, but will merge it into the next branch first since there are already changes related to single there.

lukeed added a commit that referenced this issue Jul 29, 2019
@lukeed
feat(sirv): allow --single to accept path;
fd55eca 
- Closes #35
@lukeed lukeed added the has fix label Sep 28, 2019
@lukeed
Copy link
Owner

lukeed commented Sep 28, 2019

Accessible in the current @next release.
Preparing for 1.0 release soon.

@jakobrosenberg
Copy link

jakobrosenberg commented Jan 8, 2020 •
edited
Loading

How would you use this in the @next release?

Solved
For anyone else looking:
sirv public --single catchall.html

@lukeed lukeed closed this as completed in bb948a7 Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakobrosenberg @lukeed @Conduitry