Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sirv-cli HTTP1 backward compatibility #74

Merged
merged 5 commits into from
Jul 29, 2020
Merged

Conversation

ArtskydJ
Copy link
Contributor

sirv --http2 [cert/key] servers will now allow HTTP/1 connections. This is to allow https://... requests over HTTP/1.

Supercedes #73.

@ArtskydJ ArtskydJ mentioned this pull request Jul 29, 2020
packages/sirv-cli/index.js Outdated Show resolved Hide resolved
tests/sirv-cli.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #74 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   98.48%   98.50%   +0.02%     
==========================================
  Files           2        2              
  Lines          66       67       +1     
==========================================
+ Hits           65       66       +1     
  Misses          1        1              
Impacted Files Coverage Δ
packages/sirv-cli/index.js 98.41% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ef3f4...7f170e9. Read the comment docs.

@ArtskydJ ArtskydJ requested a review from lukeed July 29, 2020 14:16
Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@lukeed lukeed merged commit 4b419bf into lukeed:master Jul 29, 2020
@ArtskydJ ArtskydJ deleted the patch-1 branch August 7, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants