Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple instances of
sirv
with different options......they currently share a
FILES
cache, meaning that files can be intercepted by the wrong handler. For example, a request for an asset like/global.css
will be handled byassets_handler
which is only supposed to deal with immutable (hashed) files. Because of that, options likesetHeaders
are disregarded.(I know this usage of
setHeaders
looks redundant, but I've found that explicitly addingmust-revalidate
rather than relying onmaxAge: 0
is necessary, otherwise the browser doesn't sendif-none-match
.)This PR fixes it by making a
FILES
cache per handler. Haven't added a test yet because I wasn't sure how that should look, since all the existing tests assume a single handler.