protocols fallback when undefined #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the latest Firefox and Edge versions, with the current version of sockette.js, the usage of opts.protocols without any check causes the browser to send "undefined" in the Sec-WebSocket-Protocol header. Protocol being undefined, the server is likely to send a 426: No Sec-WebSocket-Protocols requested supported (except if you specify on your server side that 'undefined' is a possible protocol value). Passing [] to the WebSocket constructor instead of undefined nullify the need for protocol check on the server side, as browsers stop sending the header.
lukeed
reviewed
Mar 29, 2018
There was a problem hiding this comment.
Interesting, thanks~!
I feel like this is a browser bug to be honest. Or, at least, it's very easy to check on the server side:
req.headers['Sec-WebSocket-Protocol'] !== void 0
// vs
'Sec-WebSocket-Protocol' in req.headersI'll revisit this tomorrow when I'm not so tired. Thanks again 😄
|
I forgot all about this 🙈 Thanks! After some research & poking at Mozilla, no progress. This is a Mozilla bug, but we need to patch it on our end since if/when the fix comes, it ofc wouldn't apply to users on existing browsers. Sorry for the delay, but the fix is much appreciated. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the latest Firefox and Edge versions, with the current version of sockette.js, the usage of
opts.protocolswithout any check causes the browser to sendundefinedin theSec-WebSocket-Protocolheader.Protocol being the string
undefined, the server is likely to send a426: No Sec-WebSocket-Protocols requested supported(except if you specify on your server side that 'undefined' is a possible protocol value).Passing
[]to the WebSocket constructor instead ofundefinednullify the need for protocol check on the server side, as browsers stop sending the header.