-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoload PostCSS config #284
Conversation
- forgot that `opts` param defaults to empty object - imported taskr’s ‘isEmptyObj’ fn helper
- look once for a file, then decide what to do based on result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me. Sorry for late response 👾
Thanks @hzlmn! Were you able to actually try it out locally, or are you just eyeballing it 👀 😜 |
Both, also I checked it locally with current project, everything works fine. Probably, can just manually test all common configurations... as addition |
No need to do extra checks, unless you really want to. 😄 |
Are there any blockers to merge it? 🤓 |
Nope! Going to make some other package changes tonight before pushing a |
When no
options
are passed, the@taskr/postcss
plugin will now look for & respect configs found within:(arranged by preference):.postcssrc
file (JSON-type only)package.json
postcss.config.js
file (Object
orFunction
type).postcssrc.js
file (Object
orFunction
type)As for usage, all options are available:
An error will be emitted, forcing the plugin to stop, if the final/parsed
options
is not an Object.TODO: Add autoload-config tests.Closes #283