Implement livereactload for hot loading #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemorton
force-pushed
the
feature/hot-loading
branch
from
96c73ef
to
a922827
Compare
lukemorton
force-pushed
the
feature/hot-loading
branch
from
a922827
to
dd69fd1
Compare
lukemorton
added a commit
that referenced
this pull request
Feb 14, 2016
Implement livereactload for hot loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this pull request is to implement client side hot reloading. I'm running into a few issues and would love some help.
Recreate the problem
Follow these steps to recreate the problem.
git checkout feature/hot-loadingcd examplesnpm install && sudo npm link && republic devexamples/app/views/hello/world.jsxThe error
When attempting the above I get the following error:
Expected outcome
Only the
world.jsxfile should be reloaded. I did not expect the parent files to be reloaded and as such redux and react router. How can I ensure only userland files (i.e. ones in their app directory not republic) are hot loaded?Related links