Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict Concurrency Checking #1

Closed
radmakr opened this issue Sep 20, 2023 · 0 comments · Fixed by #2
Closed

Strict Concurrency Checking #1

radmakr opened this issue Sep 20, 2023 · 0 comments · Fixed by #2
Labels
enhancement New feature or request

Comments

@radmakr
Copy link

radmakr commented Sep 20, 2023

When Strict concurrency checking is set to Complete,
this line of code - https://github.com/lukepistrol/TaskTrigger/blob/main/Sources/TaskTrigger/TaskTriggerViewModifier.swift#L36 has a warning.

Passing argument of non-sendable type 'Value' outside of main actor-isolated context may introduce data races
I'd open a PR to fix but I don't know enough about Swift concurrency yet to know how.
@lukepistrol lukepistrol added the enhancement New feature or request label Sep 20, 2023
lukepistrol added a commit that referenced this issue Sep 20, 2023
@lukepistrol
fixes #1: make Value conform to Sendable
fc28752
@lukepistrol lukepistrol mentioned this issue Sep 20, 2023
Merged
lukepistrol added a commit that referenced this issue Sep 20, 2023
@lukepistrol
Merge pull request #2 from lukepistrol/fix/sendable
17e002b 
Fixes #1: Sendable conformance for Value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1: Sendable conformance for Value lukepistrol/TaskTrigger
2 participants
@radmakr @lukepistrol