Don't render script tag when JavaScript check is disabled #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adriaanzon I'm so sorry, I completely missed this PR! I'll give it a test later and merge if everything is golden. Thanks for all your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Honey alongside Vue 3, and I'm getting a console warning saying that the script tags will be ignored by Vue. For some reason, when compiling the production JavaScript build, the script tag triggers a syntax error, resulting in a blank page.
I’ve been using the fix supplied in this PR and that solves this problem for me. Although I’m not sure if this causes a problem if you’re using Honey in a stand-alone way, without the config file (I’m not sure if that is supported).