stages/org.osbuild.qemu: make qcow2 compression optional #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarmtemp
commented
Feb 6, 2024
dustymabe
reviewed
Feb 6, 2024
lukewarmtemp
force-pushed
the
luyang-disable-compression
branch
2 times, most recently
from
7ee8a57
to
326ca7b
Compare
|
LGTM - I think while we are here let's go ahead and do this same thing for Go ahead and post it upstream when you're ready. |
Runs bootupctl generate-update-metadata in the tree to transform /usr/lib/ostree-boot into a bootupd-compatible update payload. This stage should be run on the sysroot of an ostree deployment or ostree-converted tree.
Since the stage depends on quite a specific tree state (ostree prepped tree with boot files), we can't really unit test it any simpler than generating a tree with and without running the stage and diffing the tree.
lukewarmtemp
force-pushed
the
luyang-disable-compression
branch
3 times, most recently
from
1a3f2c3
to
94c8d51
Compare
Modify the stages/org.osbuild.qemu stage such that compression is optional. This resolves the image size differences between an image built with coreos assember vs osbuild, as discussed in: coreos/fedora-coreos-tracker#1653 (comment)
lukewarmtemp
force-pushed
the
luyang-disable-compression
branch
from
94c8d51
to
fd3f5e9
Compare
|
Upstream PR: osbuild#1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the stages/org.osbuild.qemu stage such that compression is optional. This resolves the image size differences between an image built with coreos assember vs osbuild, as discussed in: coreos/fedora-coreos-tracker#1653 (comment)
Size of the image after disabling compression: