Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options method #8

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Add options method #8

merged 2 commits into from
Aug 5, 2016

Conversation

ir4y
Copy link
Contributor

@ir4y ir4y commented Aug 4, 2016

Sometimes you need to perform OPTIONS HTTP query.
It's a part of RFC7231 https://tools.ietf.org/html/rfc7231#section-4.3.7

BTW maybe it makes sense to make requestWithVerbAndUrl public

@lukewestby
Copy link
Owner

Looks good! Can you change the version number to be a minor version bump instead of a patch bump? Regarding making requestWithVerbAndUrl public, there are only so many HTTP verbs -- I think the only two left after this are TRACE and HEAD -- so they can all be included as separate functions at some point without crowding the API too much. Thanks!

Add trace and head http methods
@ir4y
Copy link
Contributor Author

ir4y commented Aug 5, 2016

It's done.

@lukewestby lukewestby merged commit 927c42a into lukewestby:master Aug 5, 2016
@lukewestby
Copy link
Owner

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants