Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: email theme #55

Closed
wants to merge 85 commits into from
Closed

feat: email theme #55

wants to merge 85 commits into from

Conversation

paulwer
Copy link
Contributor

@paulwer paulwer commented Sep 25, 2023

closes #47
references #6

Hey folks, ive managed a mailwind integration.

From my pov it may not be perfect, but it works as intended (for me).
any thoughts on this?

I've created this theme based on the mailwind front-website example.

emails should be tested for visibility on the most used e-mail clients (help wanted):

  • Apple
  • GMAIL
  • Outlook
  • Thunderbird
  • Yahoo Mail
  • WEB.de
  • Outlook.com

@CHE1RON
Copy link

CHE1RON commented Sep 28, 2023

Feel free to send emails to folkers [at] codefy [dot] de and I'll post screenshots 😉

@paulwer
Copy link
Contributor Author

paulwer commented Sep 29, 2023

@CHE1RON you should have recieved an email yesterday :)

@CHE1RON
Copy link

CHE1RON commented Sep 29, 2023

Screenshot 2023-09-29 at 10 03 23

looks good 👍

@paulwer
Copy link
Contributor Author

paulwer commented Sep 29, 2023

yahoo
Unbenannt

known issues:

  • no background at all => I guess we can ignore this

@paulwer

This comment was marked as resolved.

@CHE1RON
Copy link

CHE1RON commented Sep 29, 2023

@paulwer I mean it says right there in your screenshot: if it looks shitty, please view it in your browser 😂

@paulwer
Copy link
Contributor Author

paulwer commented Sep 29, 2023

@CHE1RON I've sended you another e-mail, please check the formatting, outlook looks now better and the other platforms are still optical the same:
Unbenannt

i changed the usage of div's to the table syntax for old email clients.
i will commit, if this looks also good on apple :)

@paulwer
Copy link
Contributor Author

paulwer commented Sep 29, 2023

outlook.com works like a charm
Unbenannt

background images are now present on all platforms i tested. <3 (only outlook destop does not display it xD)

@paulwer
Copy link
Contributor Author

paulwer commented Sep 29, 2023

thunderbird also works great <3
Unbenannt

android gmail and outlook tested as well and worked great. gmail does display it as dark mode variant, but its readable and approved from my pov.

@paulwer
Copy link
Contributor Author

paulwer commented Sep 29, 2023

@lukin any test files needed for this PR?

@CHE1RON
Copy link

CHE1RON commented Sep 30, 2023

macOS Mail:

image

@paulwer

This comment was marked as outdated.

@paulwer
Copy link
Contributor Author

paulwer commented Oct 2, 2023

within this PR, I used the mailwind logo as default logo.
should we replace it with a keycloak logo to match a more "default" - alike look or remove the logo by default, to be fit with plain installation and maybe display just the realm name, if nothing is defined...
I could also imagine a customization behavior within theme.properties, like mentioned in: #59

any opinions on that? @lukin @CHE1RON

@CHE1RON
Copy link

CHE1RON commented Oct 2, 2023

I see no apparent reason why keywind should propagate Mailwind by using its logo by default 🤔

No logo imho 👍

@paulwer
Copy link
Contributor Author

paulwer commented Oct 5, 2023

@CHE1RON is right, the logo should be optional. Therefore i will push a commit with the mentioned themeLogoUrl as property of the theme shortly. if no url is provided the realmName as heading is used accordingly.

@lukin PR is ready again :)

@paulwer
Copy link
Contributor Author

paulwer commented Jun 19, 2024

closed in favor for:
#96

@paulwer paulwer closed this Jun 19, 2024
@LeftoversTodayAppAdmin
Copy link

Hey folks,
How do I get the email template? The latest keywind branch still doesnt show any email templates at all?

@paulwer
Copy link
Contributor Author

paulwer commented Aug 22, 2024

this was closed in favor for #96.
all changes here are present in the other pr

@paulwer paulwer mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-Mail Theme